WhoX replies not caught (or ran unnecessarily)
Version is actually 0.13-rc1
I've noticed on my InspIRCd 3.0 testnet (with WhoX recently implemented) that after a user joins a channel I'm in, I get WhoX replies for the other users of the channel in my Status Buffer (the WHO is sent for the user, not the channel). If I'm the joining user, I also get the same.
I added some debug logging and the WhoX replies are being processed correctly, just not being flagged as Silent. I tested a few things to no avail so far.
I'm thinking these users shouldn't even have a who query ran on them and I can't find where they are added.
I'll update this later with more specific code findings and what I've tested. Hoping someone else can provide a bit of insight.
core: AutoWhoX, only search nickname by nickname
When running automatic WhoX, explicitly specify "n" to search by
nickname only. Don't rely on server defaults. This fixes an issue
with Quassel's autoWHO causing noise in the Status Buffer uncovered
by InspIRCd 3.0's implementation of WhoX that follows the spec.
Fix up incorrect attempt to escape "%" as "%%". Apparently,
QString::arg() doesn't need to escape this.
Before: WHO <nickname> %%chtsunfra,<unique_number>
After: WHO <nickname> n%chtsunfra,<unique_number>
Thanks to genius3000 for reporting and tracking down this issue!