Project

General

Profile

Bug #1409

Crash with no Identity

Added by kater over 4 years ago. Updated 6 days ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
05/29/2016
Due date:
% Done:

0%

Estimated time:
Version:
0.12.4
OS:
Any

Description

Start with a fresh installation of quassel. Skip create identity. Try to connect to some network.

It crash while accessing a null reference. From a null pointer to a an Identity object which, of course, does not exist.
In the patch, the returned identity is checked if it exist. If not, no new CertIdentity is created and a warning is printed.

Todo:
- Disable GUI components to connect to a network if not identity exist.
- Client::identity() should not returns pointers. Const references are fine.
If no identify exist, may throw an exception. Or return a dummy identify.

0001.patch (1.02 KB) 0001.patch kater, 05/30/2016 12:11 AM

History

#1 Updated by digitalcircuit 15 days ago

Thank you for this! I'll try looking into filing a pull request to get this issue resolved, including making sure the rest of the UI doesn't crash.

#2 Updated by digitalcircuit 6 days ago

I have filed a pull request featuring your patch. If you'd prefer attribution done differently, e.g. setting the commit author name/email, just let me know!

Thank you for your effort and patience with this.

Also available in: Atom PDF