Project

General

Profile

Bug #1388

CTCP TIME reply is ambiguous

Added by wink about 3 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
11/01/2015
Due date:
% Done:

100%

Estimated time:
Version:
0.11-pre
OS:
Any

Description

As Quassel (any version probably) doesn't add the time zone to the CTCP TIME reply, the info is useless and/or wrong.

Example:

User AAA, CET, Windows:
Received CTCP-TIME answer from AAA: Sun Nov 1 10:32:57 2015
(this is in fact UTC, as it's 11:3x currently)
should be: "Sun Nov 1 11:32:57 2015 CET" or "Sun Nov 1 10:32:57 2015 GMT/UTC" (but TZ can be hard on Windows)

User BBB, GMT, Linux:
Received CTCP-TIME answer from BBB: Sun Nov 1 10:29:37 2015
(correct, but missing "GMT" as well)

User CCC, CST, Linux:
Received CTCP-TIME answer from digitalcircuit: Sun Nov 1 04:28:35 2015
(correct, but missing "CST")

TLDR:
On Windows, UTC time without TZ name is returned.
On Linux, local time without TZ name is returned.

Related code: https://github.com/quassel/quassel/blob/master/src/core/coresessioneventprocessor.cpp#L1083

History

#1 Updated by wink about 3 years ago

Correction:

What I wrote for AAA is probably wrong, if the core is running on a machine that is UTC, then it's UTC (without a tz identifier), if the core runs on a local time, it is set to that local tz (without identifier).

#2 Updated by digitalcircuit 3 months ago

This should fixed in Quassel 0.13 master as of commit f27435c3d1b2793718e483449c7d6a62ee6cac8e. Take a look at the pull request for more example output.

-*- digitalcircuit sending CTCP-TIME request to dcircuit_dev
* Received CTCP-TIME answer from dcircuit_dev: 2018-09-12 16:25:06-05:00

Local timezone.

-*- digitalcircuit sending CTCP-VERSION request to dcircuit_dev
* Received CTCP-VERSION answer from dcircuit_dev: Quassel IRC v0.13-rc1 (0.13-rc1+59 git-7a878bd) (version date 2018-09-10 23:46:55Z) -- https://www.quassel-irc.org

VERSION replies use UTC to stay uniform regardless of timezone of the Quassel core.

(It was actually fixed much earlier, this is just the most recent change to formatting.)

#3 Updated by genius3000 3 months ago

  • Status changed from New to Resolved
  • Target version set to 0.13.0
  • % Done changed from 0 to 100

See note above from digitalcircuit; fixed in 0.13.

Also available in: Atom PDF