Project

General

Profile

Bug #1243

URLs not parsed correctly (accepts invalid chars as part of the URL)

Added by krf about 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
10/04/2013
Due date:
% Done:

100%

Estimated time:
Version:
0.9-pre
OS:
Any

Description

Example line in IRC:
<kgbot> Anmol Ahuja master * [http://git.hades.name/cgit.cgi/amarok.git/commit/?id=8ebcf55] Add missing forward declaration

Identified URL by Quassel:
http://git.hades.name/cgit.cgi/amarok.git/commit/?id=8ebcf55]

The ']' at the end of the string is not a valid char as of RFC 2396 (Uniform Resource Identifier (URI): Generic Syntax).

Quoting http://stackoverflow.com/a/1547922: "The '[' and ']' characters are <reserved> characters and should be percent escaped if not used as delimiters in the scheme-specific syntax. The spec says:".

Hence, the URL should rather be: http://git.hades.name/cgit.cgi/amarok.git/commit/?id=8ebcf55

I guess there are more problems with other characters, probably just needs fixing of a regexp.

Associated revisions

Revision c1559056 (diff)
Added by Express50 over 10 years ago

Fix URL regex

Removes unwise characters from URL regex. These characters should be percent escaped according to RFC 2396.

Fixes #1243

History

#1 Updated by Anonymous over 10 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset quassel|commit:c1559056803360cc528c578e3458a0bae33bd56c.

Also available in: Atom PDF