Project

General

Profile

Bug #860

Comma directly after an URL gets added to the URL, making websites break when you click on it

Added by Cybertinus about 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Quassel Client
Target version:
-
Start date:
11/22/2009
Due date:
% Done:

100%

Estimated time:
Version:
0.5.0
OS:
Any

Description

Well, the entire bug is written in the subject actually :p. When somebody places an URL in an chat and he adds a comma directly after it, Quassel adds the comma to the URL, making a lot of websites break. I noticed this when the following happened:

[14:26:12] <user> #imdb 0066580
[14:26:14] <channelBot> http://www.imdb.com/title/tt0066580, Woodstock (1970), 7.8/6084 votes

Quassel created a link to http://www.imdb.com/title/tt0066580, making IMDB report that the page doesn't exists.
If this could be escaped in some way, it would be great.

I've tested this with Quassel 0.5.1, not 0.5.0 as I selected below, but the option 0.5.1 wasn't added there and 0.5.0 was the closed right choice ;)

Associated revisions

Revision 6b43b399 (diff)
Added by Daniel Albers almost 10 years ago

tweak URL regex

We still allow some of the characters flagged "unwise" in RFC 2396
Fixes #860
Fixes #876

History

#1 Updated by XNeo about 10 years ago

According to RFC1738 a comma can be part of a URL, even unencoded. So the bug is in your channelBot, not in Quassel.
That said, I've come around the same issue with other chatbots -- therefore it might be nice for Quassel to have the characters configurable that are recognized as URLs.

So, this isn't a bug. It's merely a feature request.

#2 Updated by dalbers almost 10 years ago

  • Assignee set to dalbers

#3 Updated by dalbers almost 10 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF