Project

General

Profile

Bug #764

client crashes on lines from nicks like "__"

Added by m4yer over 14 years ago. Updated over 14 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
08/08/2009
Due date:
% Done:

100%

Estimated time:
Version:
0.5-pre
OS:
Any

Description

Quassel crashes if a nick only contains underslashes.

we found out, that the fault should be in uistyle.cpp, line 695

while(nick.at(nick.count() - 1 - chopCount) == '_')

in case of __ nick it strips all of it.

if needed Ive also got a crashlog here.

Crazy_Hopper already provided a patch, that i attached:

<Crazy_Hopper> Here is the simple patch to fix the crash. It's against the latest git.
<Crazy_Hopper> http://nestsite.selfip.net/~eugene/quassel_nick_hashing.patch
<Crazy_Hopper> it makes sure that at least one symbol remains after chopping the nick

quassel_nick_hashing-2.patch (644 Bytes) quassel_nick_hashing-2.patch m4yer, 08/08/2009 12:06 PM

Associated revisions

Revision eb3bfb3d (diff)
Added by Marcus Eggenberger over 14 years ago

fixes #764 - client crashes on lines from nicks like "__"
Nicks consisting only of underscores are no longer treated as a variant of some basename.

History

#1 Updated by EgS over 14 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF