Project

General

Profile

Bug #330

Compile errors/warnings when building with VS2k8

Added by APTX over 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
General / Unspecified
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Version:
0.13.0
OS:
Any

Description

These errors/warnings that appear when compiling with MS VS2k8 (express). They are ordered as they appear during the build.

C:\_C\quassel-0.3.0.1\src\qtui\chatlinemodelitem.cpp(43) : warning C4099: 'ChatLineModelItemPrivate' : type name first seen using 'class' now seen using 'struct'
c:\_c\quassel-0.3.0.1\src\qtui\chatlinemodelitem.h(29) : see declaration of 'ChatLineModelItemPrivate'

src\qtui\chatlinemodelitem.h(29):
class ChatLineModelItemPrivate;

src\qtui\chatlinemodelitem.cpp(43):
struct ChatLineModelItemPrivate {
ChatLineModel::WrapList wrapList;
};

The forward declaration of ChatLineModelItemPrivate in chatlinemodelitem.h is wrong, should be
struct ChatLineModelItemPrivate;

C:\_C\quassel-0.3.0.1\src\common\main.cpp(57) : warning C4067: unexpected tokens following preprocessor directive - expected a newline
C:\_C\quassel-0.3.0.1\src\common\main.cpp(57) : warning C4067: unexpected tokens following preprocessor directive - expected a newline
C:\_C\quassel-0.3.0.1\src\common\main.cpp(69) : warning C4067: unexpected tokens following preprocessor directive - expected a newline
C:\_C\quassel-0.3.0.1\src\common\main.cpp(69) : warning C4067: unexpected tokens following preprocessor directive - expected a newline
C:\_C\quassel-0.3.0.1\src\common\main.cpp(140) : warning C4067: unexpected tokens following preprocessor directive - expected a newline
C:\_C\quassel-0.3.0.1\src\common\main.cpp(140) : warning C4067: unexpected tokens following preprocessor directive - expected a newline

C:\_C\quassel-0.3.0.1\src\common\main.cpp, lines 57, 69 and 140 are the same:
#if defined(HAVE_EXECINFO) and not defined(Q_OS_MAC)
I assume VS complains about using "and" and "not" operators instead of && and !. Changing the lines to
#if defined(HAVE_EXECINFO) && !defined(Q_OS_MAC)
removes the warnings

C:\_C\quassel-0.3.0.1\src\core\ircserverhandler.cpp(800) : fatal error C1021: invalid preprocessor command 'warning'
NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~1.0\VC\bin\cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.

src\core\ircserverhandler.cpp(800):
#warning "Implement handle329 (Channel creation time)"

Apparently VS2k8 doesn't understand #warning
Removing the line removes the error.

Associated revisions

Revision fe73542f (diff)
Added by Marcus Eggenberger about 11 years ago

fixing BR #330 (msvc complaints)

History

#1 Updated by EgS about 11 years ago

Fixed in current git

Also available in: Atom PDF