Project

General

Profile

Bug #1326

Quassel doesn't seem to correctly handle invalid CTCP lines.

Added by AppleDash about 9 years ago. Updated about 9 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
General / Unspecified
Target version:
-
Start date:
12/18/2014
Due date:
% Done:

0%

Estimated time:
Version:
0.10.0
OS:
Any

Description

An example of a perfectly valid CTCP command is the following: "\x01ACTION does something\x01"

However, if you take that line and add another 01 byte to the end of it, like so: "\x01ACTION does something\x01\x01" (note the extra 01 byte at the end),
Quassel will print out something like this:

[12:50:18] *- SomeUser does something
[12:50:18] * Received unknown CTCP
request by

This shouldn't happen. My suggestion would be to either handle multiple trailing 01 bytes, or alternatively to simply print out the message raw as a normal channel message.
Have also seen similar issues with multiple leading 01 bytes, so that case could be handled in a similar manner.

This has been tested to happen on both 0.10.0 and v0.12-pre (0.11.0+3 git-8b5ecd2), on Windows and Ubuntu Linux.

I'm unsure if this is a bug in the client or the core, so I'm leaving it as general.

History

#1 Updated by AppleDash about 9 years ago

Errm, for some reason the formatting messed up and put a strikethrough through the pasted logs. That was not intended.

Also available in: Atom PDF