Project

General

Profile

Bug #128

State of NickList's AutoHide feature isn't correctly stored

Added by EgS almost 12 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Quassel GUI (Qt)
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Version:
0.13.0
OS:
Any

Description

When quassel is exited and the current buffer is a channel, the state to show the nicklist is set to false.

The nicklist is permanently deactivated, when the user closes it manually. This isn't particular easy to differ from autohides. Since the Nicklist is always hidden, when the current buffer is not a channel, the setting for always disabling the nicklist is set to false when the nickdock gets closed while a channel buffer is shown.

When Quassel is terminated dock is closed automatically. So when a channel was selected the state of the QAction gets messed up.

So the check in NickListWidget::changedVisibility does not suffice. Actually I have no clue how to fix this right now...

Additional information:

void NickListWidget::changedVisibility(bool visible) {
if(!selectionModel())
return;

QModelIndex currentIndex = selectionModel()->currentIndex();
if(currentIndex.data(NetworkModel::BufferTypeRole) == BufferInfo::ChannelBuffer && !visible) {
showNickListAction()->setChecked(false);
}
}

Associated revisions

Revision 4e0445e4 (diff)
Added by Marcus Eggenberger almost 12 years ago

Fixing BR #128 (Nicklist state not saved correctly) and ci of my current work.

History

#1 Updated by EgS almost 12 years ago

fixed in r660

Also available in: Atom PDF