Project

General

Profile

Bug #1267

Some irc servers send just one caracter line endings.

Added by Agge about 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/17/2014
Due date:
% Done:

100%

Estimated time:
Version:
0.10-pre
OS:
Any

Description

And that create problem with Quassel that remove 2 caracters from every line.

https://github.com/quassel/quassel/blob/master/src/core/corenetwork.cpp#L414

"s.chop(2)" should be "s.endsWith("\r\n") s.chop(2) else if s.endsWith("\n") s.chop(1)"

Associated revisions

Revision b2eee7d3 (diff)
Added by Sebastian Meyer almost 10 years ago

Checking for single char line endings

This fixes problems with IRC servers sending only single char line
endings. Before the last char on each line for thos servers would be
chopped, now Quassel checks how the line ends and chops accordingly.
Fixes #1267

Revision 900ce3a2 (diff)
Added by Sebastian Meyer over 9 years ago

Checking for single char line endings

This fixes problems with IRC servers sending only single char line
endings. Before the last char on each line for thos servers would be
chopped, now Quassel checks how the line ends and chops accordingly.
Fixes #1267

History

#1 Updated by netzvieh almost 10 years ago

created pull request with suggested changes https://github.com/quassel/quassel/pull/75

#2 Updated by Anonymous almost 10 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset quassel|commit:b2eee7d31624cc32a20f01d5b8a612c675f79564.

Also available in: Atom PDF