Bug #1267
Some irc servers send just one caracter line endings.
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/17/2014
Due date:
% Done:
100%
Estimated time:
Version:
0.10-pre
OS:
Any
Description
And that create problem with Quassel that remove 2 caracters from every line.
https://github.com/quassel/quassel/blob/master/src/core/corenetwork.cpp#L414
"s.chop(2)" should be "s.endsWith("\r\n") s.chop(2) else if s.endsWith("\n") s.chop(1)"
Associated revisions
Checking for single char line endings
This fixes problems with IRC servers sending only single char line
endings. Before the last char on each line for thos servers would be
chopped, now Quassel checks how the line ends and chops accordingly.
Fixes #1267
History
#1 Updated by netzvieh over 10 years ago
created pull request with suggested changes https://github.com/quassel/quassel/pull/75
#2 Updated by Anonymous over 10 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset quassel|commit:b2eee7d31624cc32a20f01d5b8a612c675f79564.
Checking for single char line endings
This fixes problems with IRC servers sending only single char line
endings. Before the last char on each line for thos servers would be
chopped, now Quassel checks how the line ends and chops accordingly.
Fixes #1267