Project

General

Profile

Bug #1177

genversion does not support UTF-8 paths

Added by Gallaecio almost 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Build System
Target version:
Start date:
07/07/2012
Due date:
% Done:

100%

Estimated time:
Version:
0.9-pre
OS:
Any

Description

At least if I got it right. Anyway, to illustrate the issue:

[gallaecio@afonsox build]$ make
[ 0%] Built target genversion
Could not write /home/gallaecio/proxectos/programacin/quassel/fontes/build/src/version.gen!
make2: * [CMakeFiles/genversion_run] Abortado (memoria envorcada)
make1:
[CMakeFiles/genversion_run.dir/all] Erro 2
make: *
* [all] Erro 2
[gallaecio@afonsox build]$ grep "version.gen" * -R
CMakeFiles/genversion_run.dir/build.make: ./genversion /home/gallaecio/proxectos/programaciĆ³n/quassel/fontes /home/gallaecio/proxectos/programaciĆ³n/quassel/fontes/build/src/version.gen
src/common/CMakeFiles/mod_common.dir/cmake_clean.cmake: "version.gen"

Associated revisions

Revision ffca9a2e (diff)
Added by Bas Pape over 10 years ago

Use QCoreApplication::arguments() for genversion

This prevents issues with locales and unicode paths.
Fixes #1177

History

#1 Updated by Anonymous almost 11 years ago

  • Status changed from New to Confirmed
  • Version changed from 0.7.3 to 0.8-pre

For simple assignments QString uses fromAscii, which breaks this case. However, i failed to get it to work with either of fromUtf8, fromLocal8Bit (which should use the local locale, which would be preferred, i guess). Note that the same goes for non-ascii git dirs.

#2 Updated by Anonymous over 10 years ago

  • Category set to Build System
  • Assignee set to Anonymous
  • Target version set to Some future release
  • Version changed from 0.8-pre to 0.9-pre

Fixed in PR 6

#3 Updated by Anonymous over 10 years ago

  • Status changed from Confirmed to Resolved
  • % Done changed from 0 to 100

#4 Updated by Anonymous over 10 years ago

  • Target version changed from Some future release to 0.9.0

Also available in: Atom PDF