Project

General

Profile

Bug #1274

First-time PM doesn't notify

Added by avih almost 10 years ago. Updated almost 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
04/03/2014
Due date:
% Done:

0%

Estimated time:
Version:
0.10.0
OS:
Any

Description

If I don't have a query buffer with user X, and he sends me a PM, notification will not kick. If X then sends another message after I have a query buffer for him, then notification does kick OK.

I tested it a bit, and it seems that messageInserted function only notifies for buffers which exist, but apparently at the time this is executed for a PM, the buffer doesn't yet exist. Several users on #quassels were able to reproduce the issue, and it wasn't working properly for anyone which volunteered to test.

I solved it locally by excluding query buffers from this specific filter ( https://github.com/quassel/quassel/blob/master/src/qtui/mainwin.cpp#L1485 ) but a better solution might be to check for notification after the buffer is created. FWIW, my modified build seems to work correctly - it didn't notify me when I wasn't expecting it to, and does notify me correctly when a user sends me a PM for the first time.

I tested this only with the 0.10 branch, but 0.11 probably suffers from the same issue.

History

#1 Updated by mhlavink almost 4 years ago

I'm seeing the same issue in 0.13.1. No notification for first private message when buffer does not exist already.

First messages triggers notification event that is discarded in MainWin::messagesInserted function because buffer does not exists. This buffer is created in BufferViewConfig::addBuffer after notification is processed.

Also available in: Atom PDF