Project

General

Profile

Bug #984

Input Widet does not clear if command changes active buffer

Added by Topy44 almost 7 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Quassel Client
Target version:
Start date:
06/03/2010
Due date:
% Done:

0%

Version:
0.8-pre
OS:
Any

Description

If a command issued changes the active buffer, for example "/join #channel" or "/query nickname", and "Input Widget/Enable per chat history" is checked, the Input Widget does not clear in the buffer that was active when the command was entered.

Example:
[#channel is active buffer]
/query nickname
[query with "nickname" opens]
Change back to #channel buffer
Input Widget contains "/query nickname"

Checked with win32 0.7-pre+86 git-2118039
Bug introduced with introduction of the "Enable per chat history" feature.

Associated revisions

Revision 2ed35d8a (diff)
Added by Manuel Nickschas over 5 years ago

Fix #984 without breaking topic input

Queued connection ensures that the textEdit is already reset() when InputWidget
does its thing, thus solving the history issues.

Approved by Tucos reading it 10 times. :>

Revision c79746f6 (diff)
Added by Manuel Nickschas over 5 years ago

Fix #984 without breaking topic input

Queued connection ensures that the textEdit is already reset() when InputWidget
does its thing, thus solving the history issues.

Approved by Tucos reading it 10 times. :>

History

#1 Updated by flamingspinach almost 7 years ago

Replicated.

#2 Updated by flamingspinach over 6 years ago

I can no longer replicate this. Must have been fixed at some point.

#3 Updated by flamingspinach over 6 years ago

Disregard that. I can replicate this with commands that switch the buffer to another, existent buffer, but not when the command creates the new buffer before switching to it.

#4 Updated by brot over 6 years ago

I can confirm this with v0.8-pre (0.8-pre+3 git-e7e5830)

The easiest way to reproduce is to open a query with $user and then write "/query $user" into an active buffer.

I will look into that, but i cant promise i can fix it ;)

#5 Updated by johu over 5 years ago

  • Status changed from New to Confirmed
  • Target version set to 0.8.0
  • Version changed from 0.6-pre to 0.8-pre

#6 Updated by johu over 5 years ago

  • Status changed from Confirmed to Resolved

#7 Updated by johu over 5 years ago

  • Target version changed from 0.8.0 to 0.7.4

Also available in: Atom PDF